Attention is currently required from: Marshall Dawson, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60142 )
Change subject: soc/amd/stoneyridge: split southbridge code
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/stoneyridge/fch.c:
https://review.coreboot.org/c/coreboot/+/60142/comment/b24621bd_a8ef4534
PS1, Line 175: if (gnvs) {
There's probably no need to have them in GNVS or update on S3 resume path.
So xHCI has to reload firmware from SPI flash on D0 transition?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib660fbef8dc25ba0fab803ccd82b3408878d1588
Gerrit-Change-Number: 60142
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 16 Dec 2021 07:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment