Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: drivers/intel/fsp2_0/include/fsp: fix fsp_header
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/58869/comment/7f658dc9_9ac9b6bf
PS7, Line 30: temp
In that case, isn't `multi_phase_si_init_entry_offset` should be `fsp_multi_phase_si_init_entry_offs […]
The version of the spec I have indeed only has the
`FspSiliconInitEntryOffset`
and
`FspMultiPhaseSiInitEntryOffset`
prefixed with `Fsp`, it is odd, but these names follow what is in the spec itself, unless my version is out of date (May '21)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf50f16b5e9793d946a95970fcdabc4c07289646
Gerrit-Change-Number: 58869
Gerrit-PatchSet: 8
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Name of user not set #1003801
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 20:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Name of user not set #1003801
Gerrit-MessageType: comment