Change in coreboot[master]: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku
Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku
due to overridetree.cb set disable_xhci_lfps_pm = 0, need correct condition expression to let fuction work.
BUG=b:146768983 BRANCH=octopus TEST=build coreboot with DisableXhciLfpsPM being set to 1 and flash the image to the device. Run following command to check if bits[7:4] is set 0: >iotools mmio_read32 "XHCI MMIO BAR + 0x80A4"
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I53621d7674a531adfa40e8703cb2cd01c50376b8 --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42564/1
diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index f011b65..97c77a9 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -82,7 +82,7 @@
cfg = (struct soc_intel_apollolake_config *)dev->chip_info;
- if (cfg != NULL && cfg->disable_xhci_lfps_pm) { + if (cfg != NULL && (cfg->disable_xhci_lfps_pm != 1)) { switch (google_chromeec_get_board_sku()) { case 37: case 38:
Hello Marx Wang, build bot (Jenkins), Henry Sun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42564
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku
due to overridetree.cb set disable_xhci_lfps_pm = 0, need correct condition expression to let function work.
BUG=b:146768983 BRANCH=octopus TEST=build coreboot with DisableXhciLfpsPM being set to 1 and flash the image to the device. Run following command to check if bits[7:4] is set 0: >iotools mmio_read32 "XHCI MMIO BAR + 0x80A4"
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I53621d7674a531adfa40e8703cb2cd01c50376b8 --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42564/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
Patch Set 2: Code-Review+1
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
Patch Set 2: Code-Review+1
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
Patch Set 2: Code-Review+1
Hi Reviewer,
any other cosider for this change? we still need your help for Code-Review+2
Thanks
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
Patch Set 2:
+Marco for review.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42564 )
Change subject: mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku ......................................................................
mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku
due to overridetree.cb set disable_xhci_lfps_pm = 0, need correct condition expression to let function work.
BUG=b:146768983 BRANCH=octopus TEST=build coreboot with DisableXhciLfpsPM being set to 1 and flash the image to the device. Run following command to check if bits[7:4] is set 0: >iotools mmio_read32 "XHCI MMIO BAR + 0x80A4"
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I53621d7674a531adfa40e8703cb2cd01c50376b8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42564 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Henry Sun henrysun@google.com Reviewed-by: Marco Chen marcochen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Sheng-Liang Pan: Looks good to me, but someone else must approve Marco Chen: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index f011b65..97c77a9 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -82,7 +82,7 @@
cfg = (struct soc_intel_apollolake_config *)dev->chip_info;
- if (cfg != NULL && cfg->disable_xhci_lfps_pm) { + if (cfg != NULL && (cfg->disable_xhci_lfps_pm != 1)) { switch (google_chromeec_get_board_sku()) { case 37: case 38:
-
Henry Sun (Code Review) -
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Sheng-Liang Pan (Code Review)