Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Shuming Chu (Shuming), TangYiwei.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 2: Verified+1
(2 comments)
File src/soc/intel/xeon_sp/nb_acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161738):
https://review.coreboot.org/c/coreboot/+/68912/comment/f1281e60_dbd19fed
PS2, Line 70: cpu->path.apic.node_id, cpu->path.apic.apic_id);
line length of 98 exceeds 96 columns
File src/soc/intel/xeon_sp/skx/cpu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161738):
https://review.coreboot.org/c/coreboot/+/68912/comment/7704fbf4_6079b875
PS2, Line 64: __func__, dev_path(cpu), cpu_index(), cpu->path.apic.apic_id, cpu->path.apic.node_id);
line length of 101 exceeds 96 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 31 Oct 2022 07:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment