Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - close I2C #3 - close GSPO #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 58 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/1
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index b58beaa..f53b833 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -43,11 +43,6 @@ .rise_time_ns = 60, .fall_time_ns = 25, }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, - .rise_time_ns = 150, - .fall_time_ns = 150, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 120, @@ -108,51 +103,9 @@ register "hid_desc_reg_offset" = "0x01" device i2c 5d on end end - chip drivers/generic/gpio_keys - register "name" = ""PENH"" - register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" - register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" - register "key.dev_name" = ""EJCT"" - register "key.linux_code" = "SW_PEN_INSERTED" - register "key.linux_input_type" = "EV_SW" - register "key.label" = ""pen_eject"" - device generic 0 on end - end end # I2C #1 device pci 15.2 off end # I2C #2 - device pci 15.3 on - chip drivers/i2c/sx9310 - register "desc" = ""SAR Proximity Sensor"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPP_A0)" - register "speed" = "I2C_SPEED_FAST" - register "uid" = "1" - register "reg_prox_ctrl0" = "0x10" - register "reg_prox_ctrl1" = "0x00" - register "reg_prox_ctrl2" = "0x84" - register "reg_prox_ctrl3" = "0x0e" - register "reg_prox_ctrl4" = "0x07" - register "reg_prox_ctrl5" = "0xc6" - register "reg_prox_ctrl6" = "0x20" - register "reg_prox_ctrl7" = "0x0d" - register "reg_prox_ctrl8" = "0x8d" - register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x1f" - register "reg_prox_ctrl11" = "0x00" - register "reg_prox_ctrl12" = "0x00" - register "reg_prox_ctrl13" = "0x00" - register "reg_prox_ctrl14" = "0x00" - register "reg_prox_ctrl15" = "0x00" - register "reg_prox_ctrl16" = "0x00" - register "reg_prox_ctrl17" = "0x00" - register "reg_prox_ctrl18" = "0x00" - register "reg_prox_ctrl19" = "0x00" - register "reg_sar_ctrl0" = "0x50" - register "reg_sar_ctrl1" = "0x8a" - register "reg_sar_ctrl2" = "0x3c" - device i2c 28 on end - end - end # I2C #3 + device pci 15.3 off end # I2C #3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" @@ -168,16 +121,7 @@ end end #I2C #4 device pci 1a.0 on end # eMMC - device pci 1e.3 on - chip drivers/spi/acpi - register "name" = ""CRFP"" - register "hid" = "ACPI_DT_NAMESPACE_HID" - register "uid" = "1" - register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" - device spi 1 on end - end # FPMCU - end # GSPI #1 + device pci 1e.3 off end # GSPI #1 end
end
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@11 PS1, Line 11: close nit: turn off?
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: close nit: turn off?
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: GSPO GSPI
Hello Ben Kao, Philip Chen, Justin TerAvest, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36086
to look at the new patch set (#2).
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - turn off I2C #3 - turn off GSPI #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 58 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@11 PS1, Line 11: close
nit: turn off?
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: GSPO
GSPI
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: close
nit: turn off?
Done
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci, if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
Hello Ben Kao, Philip Chen, Justin TerAvest, Tim Wawrzynczak, Marx Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36086
to look at the new patch set (#3).
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - close I2C #3 - close GSPO #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 5 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@11 PS1, Line 11: close
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: GSPO
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: close
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
you are correct.
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci
if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
you are correct.
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
Good point about the Disabled, but the I2C pins are NC in gpio.c already, except for GPP_A8, which should be set to NC. FSP configures the I2C bus pins.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
Good point about the Disabled, but the I2C pins are NC in gpio. […]
So do not set I2C bus 2/3/5 disable? right?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
So do not set I2C bus 2/3/5 disable? right?
So Tim, I catch your point, your mean keep PchSerialIoIndexI2C2/3/5 no changed, GPP_A8 has been set NC in gpio.c under the akemi. Right?
Hello Ben Kao, Philip Chen, Justin TerAvest, Tim Wawrzynczak, Marx Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36086
to look at the new patch set (#4).
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - close I2C #3 - close GSPO #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 58 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/4
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci, keep it not change
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci, keep it not change
Hello Ben Kao, Philip Chen, Justin TerAvest, Tim Wawrzynczak, Marx Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36086
to look at the new patch set (#5).
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - turn off I2C #3 - turn off GSPI #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 58 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/5
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 5: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
keep it not change
Sorry, I meant it's okay to set those as disabled.
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci,
keep it not change
Sorry, I meant it's okay to set those as disabled.
Hello Ben Kao, Philip Chen, Justin TerAvest, Tim Wawrzynczak, Marx Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36086
to look at the new patch set (#6).
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - close I2C #3 - close GSPO #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 5 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36086/6
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
Sorry, I meant it's okay to set those as disabled.
Done
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/... PS4, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci,
Sorry, I meant it's okay to set those as disabled.
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 6: Code-Review+1
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 6: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
mb/google/hatch/akemi: disable unused devices for Akemi
Akemi unused devices declare: - I2C #1 gpio_keys - close I2C #3 - close GSPO #1
BUG=b:142800988 TEST=Reboot stress test and suspend stress test, the DUT will be able to working properly
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36086 Reviewed-by: Ben Kao ben.kao@intel.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 5 insertions(+), 61 deletions(-)
Approvals: build bot (Jenkins): Verified Peichao Li: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Ben Kao: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index b58beaa..f3e0e5b 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -3,10 +3,10 @@ register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, [PchSerialIoIndexI2C1] = PchSerialIoPci, - [PchSerialIoIndexI2C2] = PchSerialIoPci, - [PchSerialIoIndexI2C3] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoDisabled, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, [PchSerialIoIndexI2C4] = PchSerialIoPci, - [PchSerialIoIndexI2C5] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoDisabled, [PchSerialIoIndexSPI0] = PchSerialIoPci, [PchSerialIoIndexSPI1] = PchSerialIoPci, [PchSerialIoIndexSPI2] = PchSerialIoDisabled, @@ -43,11 +43,6 @@ .rise_time_ns = 60, .fall_time_ns = 25, }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, - .rise_time_ns = 150, - .fall_time_ns = 150, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 120, @@ -108,51 +103,9 @@ register "hid_desc_reg_offset" = "0x01" device i2c 5d on end end - chip drivers/generic/gpio_keys - register "name" = ""PENH"" - register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" - register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" - register "key.dev_name" = ""EJCT"" - register "key.linux_code" = "SW_PEN_INSERTED" - register "key.linux_input_type" = "EV_SW" - register "key.label" = ""pen_eject"" - device generic 0 on end - end end # I2C #1 device pci 15.2 off end # I2C #2 - device pci 15.3 on - chip drivers/i2c/sx9310 - register "desc" = ""SAR Proximity Sensor"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPP_A0)" - register "speed" = "I2C_SPEED_FAST" - register "uid" = "1" - register "reg_prox_ctrl0" = "0x10" - register "reg_prox_ctrl1" = "0x00" - register "reg_prox_ctrl2" = "0x84" - register "reg_prox_ctrl3" = "0x0e" - register "reg_prox_ctrl4" = "0x07" - register "reg_prox_ctrl5" = "0xc6" - register "reg_prox_ctrl6" = "0x20" - register "reg_prox_ctrl7" = "0x0d" - register "reg_prox_ctrl8" = "0x8d" - register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x1f" - register "reg_prox_ctrl11" = "0x00" - register "reg_prox_ctrl12" = "0x00" - register "reg_prox_ctrl13" = "0x00" - register "reg_prox_ctrl14" = "0x00" - register "reg_prox_ctrl15" = "0x00" - register "reg_prox_ctrl16" = "0x00" - register "reg_prox_ctrl17" = "0x00" - register "reg_prox_ctrl18" = "0x00" - register "reg_prox_ctrl19" = "0x00" - register "reg_sar_ctrl0" = "0x50" - register "reg_sar_ctrl1" = "0x8a" - register "reg_sar_ctrl2" = "0x3c" - device i2c 28 on end - end - end # I2C #3 + device pci 15.3 off end # I2C #3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" @@ -168,16 +121,7 @@ end end #I2C #4 device pci 1a.0 on end # eMMC - device pci 1e.3 on - chip drivers/spi/acpi - register "name" = ""CRFP"" - register "hid" = "ACPI_DT_NAMESPACE_HID" - register "uid" = "1" - register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" - device spi 1 on end - end # FPMCU - end # GSPI #1 + device pci 1e.3 off end # GSPI #1 end
end
-
Ben Kao (Code Review) -
Patrick Georgi (Code Review)
-
Peichao Li (Code Review)
-
Tim Wawrzynczak (Code Review)