Attention is currently required from: Paul Menzel, Zheng Bao. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59919 )
Change subject: mb/google/guybrush/var/nipperkin: Board values for eDP tuning ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59919/comment/e57ea5f8_78d3905b PS5, Line 7: Google/Nipperkin
mb/google/guybrush/var/nipperkin
Done
https://review.coreboot.org/c/coreboot/+/59919/comment/f6a06c60_296edaac PS5, Line 9: These values are got from experiment.
How exactly?
Done
https://review.coreboot.org/c/coreboot/+/59919/comment/f2c6b3b7_87c41646 PS5, Line 9: document
That means the testing document? (Not the datasheet. […]
Done
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59919/comment/2f08af0e_544c6cb3 PS5, Line 102: 0x1F
In coreboot it’s common to write it lowercase.
Done