Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31549 )
Change subject: cpu/x86/pae/pgtbl: Add memset with PAE ......................................................................
Patch Set 7:
(10 comments)
What about Rudolf’s suggestion on the mailing list?
https://review.coreboot.org/#/c/31549/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31549/7//COMMIT_MSG@12 PS7, Line 12: Add Documentation. : Tested on wedge100s. : Takes less than 2 seconds to clear 8GiB of DRAM. Please format this as a list. Dots/periods can be removed from the first two items.
https://review.coreboot.org/#/c/31549/7/Documentation/arch/x86/pae.md File Documentation/arch/x86/pae.md:
https://review.coreboot.org/#/c/31549/7/Documentation/arch/x86/pae.md@4 PS7, Line 4: ``src/cpu/x86/pae/`` Isn’t one ` enough?
https://review.coreboot.org/#/c/31549/7/Documentation/arch/x86/pae.md@13 PS7, Line 13: uint64_t Can’t this bee offset_t or size_t?
https://review.coreboot.org/#/c/31549/7/Documentation/arch/x86/pae.md@18 PS7, Line 18: the *scratch memory* doesn't overlap with the range to be cleared. Please add a blank line below.
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c File src/cpu/x86/pae/pgtbl.c:
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@116 PS7, Line 116: are is
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@118 PS7, Line 118: are is
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@123 PS7, Line 123: * Document the return value? Use CB_SUCCESS macro?
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@128 PS7, Line 128: ssize_t offset; Why not `offset_t`?
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@132 PS7, Line 132: page-tables Above you spell it *pagetables*. I’d prefer *page tables* though. ;-)
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@148 PS7, Line 148: * Point the page directory pointers at the page : * directories. Dosen’t this fit on one line?