Attention is currently required from: Reka Norman, Tim Wawrzynczak. Hello Reka Norman,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/61694
to review the following change.
Change subject: mb/google/brya/var/nivviks: Implement WWAN power sequencing ......................................................................
mb/google/brya/var/nivviks: Implement WWAN power sequencing
Nissa is using the FM101, which has the following power sequencing requirements:
Power on: assert WWAN_EN, delay 20 ms, deassert WWAN_RST_L Power off: assert WWAN_RST_L, delay 20 ms, deassert WWAN_EN
Add a power resource to the USB device, and use wwan_power.asl to handle the power off sequence.
BUG=b:217092522 TEST=abuild -a -x -c max -p none -t google/brya -b nivviks
Signed-off-by: Reka Norman rekanorman@google.com Change-Id: Ibe1b863a550c6af1ac3eb98f2aaa3db15b149ada --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h M src/mainboard/google/brya/variants/nivviks/overridetree.cb 3 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/61694/1
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 7613730..935d2e9 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -85,6 +85,7 @@ bool "-> Nivviks" select BOARD_GOOGLE_BASEBOARD_NISSA select DRIVERS_INTEL_MIPI_CAMERA + select HAVE_WWAN_POWER_SEQUENCE
config BOARD_GOOGLE_NEREID bool "-> Nereid" diff --git a/src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h b/src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h index c4fe342..c96b01f 100644 --- a/src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h +++ b/src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h @@ -5,4 +5,8 @@
#include <baseboard/gpio.h>
+#define WWAN_FCPO GPP_D6 +#define WWAN_RST GPP_F12 +#define T2_OFF_MS 20 + #endif diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 646dcb1..397025b 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -281,6 +281,11 @@ chip drivers/usb/acpi register "desc" = ""USB2 WWAN"" register "type" = "UPC_TYPE_INTERNAL" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F12)" + register "reset_off_delay_ms" = "20" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "enable_delay_ms" = "20" device ref usb2_port4 on probe DB_USB DB_1C_LTE end