Change in coreboot[master]: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid - coreboot-gerrit

25 Dec 2021


      Attention is currently required from: Reka Norman, Paul Menzel, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 )
Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/60271/comment/082e541f_cdbe4432 
PS4, Line 3: 	select SOC_INTEL_ALDERLAKE_PCH_P
...
can this one and line #10 can move to a separate CL to make it clear. […]
@Reka: I have addressed this comment here CB:60378
You might need a rebase.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5
Gerrit-Change-Number: 60271
Gerrit-PatchSet: 4
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Reka Norman rekanorman@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Reka Norman rekanorman@google.com
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Sat, 25 Dec 2021 15:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment