Attention is currently required from: Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli.
Sumeet R Pawnikar has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/69217?usp=email )
Change subject: soc/intel/alderlake: Set PL1 Time to Intel default 56s for certain CPUs
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/69217/comment/18dff202_192213d1?usp... :
PS3, Line 16: MOBILE_SKU_PL1_TIME_SEC
It might make sense for me to change this macro name as well which reflects the Time in Seconds, something like this "POWER_LIMIT1_TIME_28_SEC"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69217?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02c56b981d956bef58ae90f7f317a231416a2e54
Gerrit-Change-Number: 69217
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 04 Jul 2024 10:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No