Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50849 )
Change subject: util/cbmem: Update Makefiles ......................................................................
util/cbmem: Update Makefiles
- Add a help target - Add the -Wshadow option - Add a way to disable -Werror
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Icd4e5cf51d60254d274c6e5093285cd49ff1607a Reviewed-on: https://review.coreboot.org/c/coreboot/+/50849 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/cbmem/Makefile 1 file changed, 9 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index e67efae..a170875 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -7,7 +7,8 @@ INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -CFLAGS += -Wall -Wextra -Wmissing-prototypes -Werror +WERROR=-Werror +CFLAGS += -Wall -Wextra -Wmissing-prototypes -Wshadow $(WERROR) CPPFLAGS += -I . -I $(ROOT)/commonlib/include -I $(ROOT)/commonlib/bsd/include CPPFLAGS += -include $(ROOT)/commonlib/bsd/include/commonlib/bsd/compiler.h
@@ -29,6 +30,12 @@ .dependencies: @$(CC) $(CFLAGS) $(CPPFLAGS) -MM *.c > .dependencies
-.PHONY: all clean distclean +help: + @echo "${PROGRAM}: View machine's cbmem contents" + @echo "Targets: all, clean, distclean, help, install" + @echo "To disable warnings as errors, run make as:" + @echo " make all WERROR=""" + +.PHONY: all clean distclean install help
-include .dependencies