[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver - coreboot-gerrit

12 Jun 2023


      Attention is currently required from: Matt DeVillier, Paul Menzel, Tarun Tuli.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email )
Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver
......................................................................
Patch Set 17:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74885/comment/99b56765_55178588 :
PS2, Line 13:
...
Why use an ACPI driver and not a “native” one?
please see Subrata's response
Patchset:
PS2:
...
...
why use ASL here vs runtime-generated AML, like i2c touchscreens do? […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0
Gerrit-Change-Number: 74885
Gerrit-PatchSet: 17
Gerrit-Owner: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 12 Jun 2023 16:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment