Attention is currently required from: Arthur Heymans, Benjamin Doron, Maximilian Brune, Nico Huber, Paul Menzel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75712?usp=email )
Change subject: arch/x86/tables.c: Drop placing ACPI and SMBIOS in lower memory
......................................................................
Patch Set 1:
(3 comments)
File src/arch/x86/tables.c:
https://review.coreboot.org/c/coreboot/+/75712/comment/284cfc7d_d1fa226a :
PS1, Line 31: if (high_table_pointer) {
For symmetry, do this too?
https://review.coreboot.org/c/coreboot/+/75712/comment/c3ce0b57_3404519a :
PS1, Line 60: if (high_table_pointer) {
For symmetry, do this too?
https://review.coreboot.org/c/coreboot/+/75712/comment/3eb828c8_022f49c9 :
PS1, Line 83: /* Write ACPI tables to F segment and high tables area */
Second paragraph of the comment seems obsolete.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I216e7c713d112ad1012b0beaf26196967988b951
Gerrit-Change-Number: 75712
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 07 Jun 2023 18:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment