Change in coreboot[master]: technotes/rebuilding-coreboot-image-generation: Mark manifest as code
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36199 )
Change subject: technotes/rebuilding-coreboot-image-generation: Mark manifest as code ......................................................................
technotes/rebuilding-coreboot-image-generation: Mark manifest as code
Mark the manifest example as inline code.
Change-Id: I38cb1a508ec9ccb39cb39048de3742a5cb595f7b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/36199/1
diff --git a/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md b/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md index d2a8fdc..d09068e 100644 --- a/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md +++ b/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md @@ -154,6 +154,7 @@ the regions are filled, one data region must be post-processed to contain signatures to enable verifying other regions.
+``` Chipset manifest ================ # A region called IFD, starting at 0, ending at 4K @@ -249,9 +250,10 @@ # overrides the cbfsdefault above group payload: ecrw.bin name=ecrw hash=sha256 group payload: pdrw.bin name=pdrw hash=sha256 +```
manifest parsing -================ +---------------- The exact BNF is work in progress.
Some parser rules are
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/36199 )
Change subject: technotes/coreboot-image-generation: Fix markdown ......................................................................
technotes/coreboot-image-generation: Fix markdown
The manifest example has to be marked as code. The Manifest parsing section header should be L2 and finally # is a special character in markdown.
Change-Id: I38cb1a508ec9ccb39cb39048de3742a5cb595f7b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/36199/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36199 )
Change subject: technotes/coreboot-image-generation: Fix markdown ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36199 )
Change subject: technotes/coreboot-image-generation: Fix markdown ......................................................................
technotes/coreboot-image-generation: Fix markdown
The manifest example has to be marked as code. The Manifest parsing section header should be L2 and finally # is a special character in markdown.
Change-Id: I38cb1a508ec9ccb39cb39048de3742a5cb595f7b Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36199 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md b/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md index d2a8fdc..9accbfe 100644 --- a/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md +++ b/Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md @@ -154,6 +154,7 @@ the regions are filled, one data region must be post-processed to contain signatures to enable verifying other regions.
+``` Chipset manifest ================ # A region called IFD, starting at 0, ending at 4K @@ -249,14 +250,15 @@ # overrides the cbfsdefault above group payload: ecrw.bin name=ecrw hash=sha256 group payload: pdrw.bin name=pdrw hash=sha256 +```
manifest parsing -================ +---------------- The exact BNF is work in progress.
Some parser rules are * one line per statement -* # introduces a command until the end of line +* '#' introduces a command until the end of line
Some processing rules * When there’s a conflict (eg. two statements on what to do to a region,
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)