Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995?usp=email )
Change subject: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS
......................................................................
Patch Set 41:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse_lite_cmos.h:
https://review.coreboot.org/c/coreboot/+/74995/comment/93d25d10_77c6224b :
PS41, Line 19:
Yes, it is true that the CMOS APIs are local to CSE Lite and do not need to be exposed outside of the CSE but I am still not convinced that if it is a good idea to keep the source and header files in the same folder.
take a look into https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/... for example, if we don't want to expose the header outside the scope of common code then we need to limit that within the same directory. Unable to follow what is the reservation ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74995?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786
Gerrit-Change-Number: 74995
Gerrit-PatchSet: 41
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Sun, 18 Jun 2023 08:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Gerrit-MessageType: comment