Attention is currently required from: Julius Werner, Moritz Fischer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50887 )
Change subject: soc/rockchip/rk3399/sdram: Use rank_mask in CA training
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/rockchip/rk3399/sdram.c:
https://review.coreboot.org/c/coreboot/+/50887/comment/40a8da53_fb470abb
PS1, Line 629: rank_mask = (rank == 1) ? 0x1 : 0x3;
Does `rank` here mean `number of ranks`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85f449af9f946ad677808800cdbe59e2001202c3
Gerrit-Change-Number: 50887
Gerrit-PatchSet: 1
Gerrit-Owner: Moritz Fischer
moritzf@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Moritz Fischer
moritzf@google.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 00:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment