Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80357?usp=email )
Change subject: arch/x86/mpspec: reduce scope of smp_write_ioapic ......................................................................
arch/x86/mpspec: reduce scope of smp_write_ioapic
smp_write_ioapic is only called from smp_write_ioapic_from_hw within the same compilation unit, so reduce its scope by making it a static function.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I6a1bbfd50ae9d6c8ab18f478ae9bae3f8bf5e10d --- M src/arch/x86/include/arch/smp/mpspec.h M src/arch/x86/mpspec.c 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/80357/1
diff --git a/src/arch/x86/include/arch/smp/mpspec.h b/src/arch/x86/include/arch/smp/mpspec.h index 48e5732..0b5ca47 100644 --- a/src/arch/x86/include/arch/smp/mpspec.h +++ b/src/arch/x86/include/arch/smp/mpspec.h @@ -225,8 +225,6 @@ u8 cpuflag, u32 cpufeature, u32 featureflag); void smp_write_processors(struct mp_config_table *mc); -void smp_write_ioapic(struct mp_config_table *mc, - u8 id, u8 ver, void *apicaddr);
/* Call smp_write_ioapic() and return IOAPIC ID field. */ u8 smp_write_ioapic_from_hw(struct mp_config_table *mc, void *apicaddr); diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index b8bdb09..ac3fc79 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -206,7 +206,7 @@ * Entry Type, APIC ID, Version, * APIC Flags:EN, Address */ -void smp_write_ioapic(struct mp_config_table *mc, +static void smp_write_ioapic(struct mp_config_table *mc, u8 id, u8 ver, void *apicaddr) { struct mpc_config_ioapic *mpc;