Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/f6d6e688_2ab3008a PS5, Line 70: PAD_GPO(GPIO_31, HIGH), Please make this PAD_NC(GPIO_31)
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/d53f730d_7990a45a PS5, Line 13: PAD_NC(GPIO_31), nit: could be removed.
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/fceaf45c_0e9e2ecc PS5, Line 39: /* Unused */ Override for GPIO_31 and GPIO_70 is not needed here because it matches base_gpio. Please remove.