Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72488 )
Change subject: cpu,soc/intel: Use acpigen_write_processor_device() ......................................................................
cpu,soc/intel: Use acpigen_write_processor_device()
Use acpigen_write_processor_device() instead of deprecated acpigen_write_processor().
Change-Id: I1448e0a8845b3a1beee0a3ed744358944faf66d8 Signed-off-by: Elyes Haouas ehaouas@noos.fr Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/72488 Reviewed-by: Paul Menzel paulepanter@mailbox.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/haswell/acpi.c M src/cpu/intel/model_2065x/acpi.c M src/cpu/intel/model_206ax/acpi.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c 5 files changed, 37 insertions(+), 18 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c index a53978d..1e1c724 100644 --- a/src/cpu/intel/haswell/acpi.c +++ b/src/cpu/intel/haswell/acpi.c @@ -337,9 +337,9 @@
for (cpuID = 1; cpuID <= numcpus; cpuID++) { for (coreID = 1; coreID <= cores_per_package; coreID++) { - /* Generate processor _SB.CPUx */ - acpigen_write_processor( - (cpuID - 1) * cores_per_package+coreID - 1, 0, 0); + /* Generate Scope(_SB) { Device(CPUx */ + acpigen_write_processor_device( + (cpuID - 1) * cores_per_package+coreID - 1);
/* Generate P-state tables */ generate_P_state_entries( @@ -352,7 +352,7 @@ generate_T_state_entries( cpuID - 1, cores_per_package);
- acpigen_pop_len(); + acpigen_write_processor_device_end(); } }
diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c index 0409b8a..834a3bb 100644 --- a/src/cpu/intel/model_2065x/acpi.c +++ b/src/cpu/intel/model_2065x/acpi.c @@ -215,9 +215,9 @@
for (cpuID = 1; cpuID <= numcpus; cpuID++) { for (coreID = 1; coreID <= cores_per_package; coreID++) { - /* Generate processor _SB.CPUx */ - acpigen_write_processor( - (cpuID-1)*cores_per_package+coreID-1, 0, 0); + /* Generate Scope(_SB) { Device(CPUx */ + acpigen_write_processor_device( + (cpuID-1)*cores_per_package+coreID-1);
/* Generate P-state tables */ generate_P_state_entries( @@ -230,7 +230,7 @@ generate_T_state_entries( cpuID-1, cores_per_package);
- acpigen_pop_len(); + acpigen_write_processor_device_end(); } }
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index a305c01..d7c048d 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -306,9 +306,9 @@
for (cpuID = 1; cpuID <= numcpus; cpuID++) { for (coreID = 1; coreID <= cores_per_package; coreID++) { - /* Generate processor _SB.CPUx */ - acpigen_write_processor( - (cpuID-1)*cores_per_package+coreID-1, 0, 0); + /* Generate Scope(_SB) { Device(CPU */ + acpigen_write_processor_device( + (cpuID-1)*cores_per_package+coreID-1);
/* Generate P-state tables */ generate_P_state_entries( @@ -321,7 +321,7 @@ generate_T_state_entries( cpuID-1, cores_per_package);
- acpigen_pop_len(); + acpigen_write_processor_device_end(); } }
diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index 75c2863..42e4b26 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -266,8 +266,8 @@ const struct pattrs *pattrs = pattrs_get();
for (core = 0; core < pattrs->num_cpus; core++) { - /* Generate processor _SB.CPUx */ - acpigen_write_processor(core, 0, 0); + /* Generate Scope(_SB) { Device(CPUx */ + acpigen_write_processor_device(core);
/* Generate P-state tables */ generate_p_state_entries(core, pattrs->num_cpus); @@ -278,7 +278,7 @@ /* Generate T-state tables */ generate_t_state_entries(core, pattrs->num_cpus);
- acpigen_pop_len(); + acpigen_write_processor_device_end(); }
/* PPKG is usually used for thermal management diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c index 46a8771..9ef7a75 100644 --- a/src/soc/intel/braswell/acpi.c +++ b/src/soc/intel/braswell/acpi.c @@ -282,8 +282,8 @@ const struct pattrs *pattrs = pattrs_get();
for (core = 0; core < pattrs->num_cpus; core++) { - /* Generate processor _SB.CPUx */ - acpigen_write_processor(core, 0, 0); + /* Generate Scope(_SB) { Device(CPUx */ + acpigen_write_processor_device(core);
/* Generate P-state tables */ generate_p_state_entries(core, pattrs->num_cpus); @@ -294,7 +294,7 @@ /* Generate T-state tables */ generate_t_state_entries(core, pattrs->num_cpus);
- acpigen_pop_len(); + acpigen_write_processor_device_end(); }
/* PPKG is usually used for thermal management
-
Kyösti Mälkki (Code Review)