Attention is currently required from: Jamie Ryu, Jérémy Compostella, Paul Menzel.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85146?usp=email )
Change subject: mb/google/fatcat: Limit Power Limit when battery is missing
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
@subratabanik@google.com, I re-tested this patch today and I realized the current implementation may be a bit problematic as all the board without a battery attached will lower PL4. Would it make sense to have a FW_CONFIG flag to not apply this policy ?
Unfortunately, we won't be helped here much as Chromebooks are meant for with battery.
The alternatives could be
1. set batteryfake from EC
2. Use dolos for battery emulators
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77e
Gerrit-Change-Number: 85146
Gerrit-PatchSet: 17
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 11 Dec 2024 01:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com