Attention is currently required from: Felix Singer, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Patrick Rudolph, Tim Crawford, SRIDHAR SIRICILLA, Tim Wawrzynczak, Evgeny Zinoviev, Felix Held.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................
Patch Set 91:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/52800/comment/b481f644_8d51b981
PS90, Line 991: /* (CS)ME Disable Command */
: struct me_disable_command {
: struct mkhi_hdr hdr;
: uint32_t rule_id;
: uint8_t rule_len;
: uint32_t rule_data;
: } __packed me_disable = {
: .hdr = {
: .group_id = MKHI_GROUP_ID_FWCAPS,
: .command = MKHI_SET_ME_DISABLE,
: },
: .rule_id = ME_DISABLE_RULE_ID,
: .rule_len = ME_DISABLE_RULE_LENGTH,
: .rule_data = ME_DISABLE_COMMAND,
: };
:
: struct me_disable_reply {
: struct mkhi_hdr hdr;
: uint32_t rule_id;
: } __packed;
:
: struct me_disable_reply disable_reply;
:
: size_t disable_reply_size;
:
: /* (CS)ME Enable Command */
: struct me_enable_command {
: struct mkhi_hdr hdr;
: } me_enable = {
: .hdr = {
: .group_id = MKHI_GROUP_ID_BUP_COMMON,
: .command = MKHI_SET_ME_ENABLE,
: },
: };
:
: struct me_enable_reply {
: struct mkhi_hdr hdr;
: } __packed;
:
: struct me_enable_reply enable_reply;
:
: size_t enable_reply_size;
Is there a reason these are global-scoped and not at least file-scoped or function-scoped? I don't t […]
Is that okay?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20
Gerrit-Change-Number: 52800
Gerrit-PatchSet: 91
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment