Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21653
Change subject: smbus: Fix a typo ("Set the device I'm talking too") ......................................................................
smbus: Fix a typo ("Set the device I'm talking too")
Change-Id: Ia14bbdfe973cec4b366879cd2ed5602b43754260 Signed-off-by: Jonathan Neuschäfer j.neuschaefer@gmx.net --- M src/soc/amd/stoneyridge/smbus.c M src/soc/intel/broadwell/smbus_common.c M src/soc/intel/common/block/smbus/smbuslib.c M src/soc/intel/fsp_broadwell_de/smbus_common.c M src/soc/intel/sch/smbus.h M src/southbridge/amd/agesa/hudson/smbus.c M src/southbridge/amd/amd8111/amd8111_smbus.h M src/southbridge/amd/cimx/sb700/smbus.c M src/southbridge/amd/cimx/sb800/smbus.c M src/southbridge/amd/cimx/sb900/smbus.c M src/southbridge/amd/pi/hudson/smbus.c M src/southbridge/amd/sb600/smbus.c M src/southbridge/amd/sb700/smbus.c M src/southbridge/amd/sb800/smbus.c M src/southbridge/broadcom/bcm5785/smbus.h M src/southbridge/intel/common/smbus.c M src/southbridge/nvidia/mcp55/smbus.h M src/southbridge/sis/sis966/early_smbus.c M util/romcc/tests/raminit_test.c M util/romcc/tests/raminit_test1.c M util/romcc/tests/raminit_test2.c M util/romcc/tests/simple_test4.c M util/romcc/tests/simple_test5.c M util/romcc/tests/simple_test6.c M util/romcc/tests/simple_test61.c 25 files changed, 74 insertions(+), 74 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21653/1
diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c index aef3edf..b216f1e 100644 --- a/src/soc/amd/stoneyridge/smbus.c +++ b/src/soc/amd/stoneyridge/smbus.c @@ -59,7 +59,7 @@ if (smbus_wait_until_ready(smbus_io_base) < 0) return -2; /* not ready */
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -87,7 +87,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -113,7 +113,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -142,7 +142,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/soc/intel/broadwell/smbus_common.c b/src/soc/intel/broadwell/smbus_common.c index 29b7dbb..bec988f 100644 --- a/src/soc/intel/broadwell/smbus_common.c +++ b/src/soc/intel/broadwell/smbus_common.c @@ -68,7 +68,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); @@ -112,7 +112,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c index a865abf..27b4ad5 100644 --- a/src/soc/intel/common/block/smbus/smbuslib.c +++ b/src/soc/intel/common/block/smbus/smbuslib.c @@ -58,7 +58,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); @@ -103,7 +103,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); diff --git a/src/soc/intel/fsp_broadwell_de/smbus_common.c b/src/soc/intel/fsp_broadwell_de/smbus_common.c index 26bb4fd..20e8f09 100644 --- a/src/soc/intel/fsp_broadwell_de/smbus_common.c +++ b/src/soc/intel/fsp_broadwell_de/smbus_common.c @@ -67,7 +67,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); @@ -113,7 +113,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); diff --git a/src/soc/intel/sch/smbus.h b/src/soc/intel/sch/smbus.h index e34ca52..19d70b6 100644 --- a/src/soc/intel/sch/smbus.h +++ b/src/soc/intel/sch/smbus.h @@ -59,7 +59,7 @@ /* Setup transaction */ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); diff --git a/src/southbridge/amd/agesa/hudson/smbus.c b/src/southbridge/amd/agesa/hudson/smbus.c index 9aa152b..ce0361a 100644 --- a/src/southbridge/amd/agesa/hudson/smbus.c +++ b/src/southbridge/amd/agesa/hudson/smbus.c @@ -64,7 +64,7 @@ return -2; /* not ready */ }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -94,7 +94,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -122,7 +122,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -153,7 +153,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/amd8111/amd8111_smbus.h b/src/southbridge/amd/amd8111/amd8111_smbus.h index f82bb19..6b2459f 100644 --- a/src/southbridge/amd/amd8111/amd8111_smbus.h +++ b/src/southbridge/amd/amd8111/amd8111_smbus.h @@ -62,7 +62,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR); /* set the command/address... */ outb(0, smbus_io_base + SMBHSTCMD); @@ -107,7 +107,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR); /* set the command/address... */ outb(0, smbus_io_base + SMBHSTCMD); @@ -150,7 +150,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR); /* set the command/address... */ outb(address & 0xFF, smbus_io_base + SMBHSTCMD); @@ -195,7 +195,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR); outb(address & 0xFF, smbus_io_base + SMBHSTCMD); /* set up for a byte data write */ /* FIXME */ @@ -235,7 +235,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR); /* set the command/address... */ outb(cmd & 0xFF, smbus_io_base + SMBHSTCMD); @@ -290,7 +290,7 @@ /* setup transaction */ /* disable interrupts */ outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR); /* set the command/address... */ outb(cmd & 0xFF, smbus_io_base + SMBHSTCMD); diff --git a/src/southbridge/amd/cimx/sb700/smbus.c b/src/southbridge/amd/cimx/sb700/smbus.c index 8ae6d3b..9d78cd0 100644 --- a/src/southbridge/amd/cimx/sb700/smbus.c +++ b/src/southbridge/amd/cimx/sb700/smbus.c @@ -67,7 +67,7 @@ }
printk(BIOS_SPEW, "SB700 - Smbus.c - do_smbus_recv_byte - Start.\n"); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -99,7 +99,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -128,7 +128,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -160,7 +160,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/cimx/sb800/smbus.c b/src/southbridge/amd/cimx/sb800/smbus.c index 80395f1..53b0a13 100644 --- a/src/southbridge/amd/cimx/sb800/smbus.c +++ b/src/southbridge/amd/cimx/sb800/smbus.c @@ -68,7 +68,7 @@ }
printk(BIOS_DEBUG, "SB800 - Smbus.c - do_smbus_recv_byte - Start.\n"); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -101,7 +101,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -131,7 +131,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -164,7 +164,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/cimx/sb900/smbus.c b/src/southbridge/amd/cimx/sb900/smbus.c index 7d11898..aaa0968 100644 --- a/src/southbridge/amd/cimx/sb900/smbus.c +++ b/src/southbridge/amd/cimx/sb900/smbus.c @@ -68,7 +68,7 @@ }
printk(BIOS_INFO, "SB900 - Smbus.c - do_smbus_recv_byte - Start.\n"); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -101,7 +101,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -131,7 +131,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -164,7 +164,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/pi/hudson/smbus.c b/src/southbridge/amd/pi/hudson/smbus.c index 9aa152b..ce0361a 100644 --- a/src/southbridge/amd/pi/hudson/smbus.c +++ b/src/southbridge/amd/pi/hudson/smbus.c @@ -64,7 +64,7 @@ return -2; /* not ready */ }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -94,7 +94,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -122,7 +122,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -153,7 +153,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/sb600/smbus.c b/src/southbridge/amd/sb600/smbus.c index 6c61cf0..990098f 100644 --- a/src/southbridge/amd/sb600/smbus.c +++ b/src/southbridge/amd/sb600/smbus.c @@ -64,7 +64,7 @@ return -2; /* not ready */ }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -94,7 +94,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -121,7 +121,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -151,7 +151,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/sb700/smbus.c b/src/southbridge/amd/sb700/smbus.c index 373c339..58bbe4c 100644 --- a/src/southbridge/amd/sb700/smbus.c +++ b/src/southbridge/amd/sb700/smbus.c @@ -111,7 +111,7 @@ return -2; /* not ready */ }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -141,7 +141,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -168,7 +168,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -198,7 +198,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/amd/sb800/smbus.c b/src/southbridge/amd/sb800/smbus.c index d9bb746..89244f4 100644 --- a/src/southbridge/amd/sb800/smbus.c +++ b/src/southbridge/amd/sb800/smbus.c @@ -67,7 +67,7 @@ return -2; /* not ready */ }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -97,7 +97,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -125,7 +125,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -156,7 +156,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/broadcom/bcm5785/smbus.h b/src/southbridge/broadcom/bcm5785/smbus.h index 76c593b..8ebe203 100644 --- a/src/southbridge/broadcom/bcm5785/smbus.h +++ b/src/southbridge/broadcom/bcm5785/smbus.h @@ -85,7 +85,7 @@ return -2; // not ready }
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -115,7 +115,7 @@ /* set the command... */ outb(val, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|0 , smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -142,7 +142,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBHSTADDR);
byte = inb(smbus_io_base + SMBHSTCTRL); @@ -172,7 +172,7 @@ /* set the command/address... */ outb(address & 0xff, smbus_io_base + SMBHSTCMD);
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|0 , smbus_io_base + SMBHSTADDR);
/* output value */ diff --git a/src/southbridge/intel/common/smbus.c b/src/southbridge/intel/common/smbus.c index e6b1188..99608dc 100644 --- a/src/southbridge/intel/common/smbus.c +++ b/src/southbridge/intel/common/smbus.c @@ -115,7 +115,7 @@ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN, smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); @@ -164,7 +164,7 @@ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN, smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(address & 0xff, smbus_base + SMBHSTCMD); @@ -217,7 +217,7 @@ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN, smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(cmd & 0xff, smbus_base + SMBHSTCMD); @@ -292,7 +292,7 @@ /* Disable interrupts */ outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN, smbus_base + SMBHSTCTL); - /* Set the device I'm talking too */ + /* Set the device I'm talking to */ outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD); /* Set the command/address... */ outb(cmd & 0xff, smbus_base + SMBHSTCMD); diff --git a/src/southbridge/nvidia/mcp55/smbus.h b/src/southbridge/nvidia/mcp55/smbus.h index a7a6679..a588a09 100644 --- a/src/southbridge/nvidia/mcp55/smbus.h +++ b/src/southbridge/nvidia/mcp55/smbus.h @@ -56,7 +56,7 @@ unsigned char global_status_register; unsigned char byte;
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD); smbus_delay();
@@ -90,7 +90,7 @@ outb(val, smbus_io_base + SMBHSTCMD); smbus_delay();
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD); smbus_delay();
@@ -114,7 +114,7 @@ unsigned char global_status_register; unsigned char byte;
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD); smbus_delay(); /* set the command/address... */ @@ -148,7 +148,7 @@ outb(val, smbus_io_base + SMBHSTDAT0); smbus_delay();
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD); smbus_delay();
diff --git a/src/southbridge/sis/sis966/early_smbus.c b/src/southbridge/sis/sis966/early_smbus.c index 99f8bd4..3c8998e 100644 --- a/src/southbridge/sis/sis966/early_smbus.c +++ b/src/southbridge/sis/sis966/early_smbus.c @@ -62,7 +62,7 @@ unsigned char global_status_register; unsigned char byte;
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD); smbus_delay();
@@ -97,7 +97,7 @@ outb(val, smbus_io_base + SMBHSTCMD); smbus_delay();
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD); smbus_delay();
@@ -161,7 +161,7 @@ outb(val, smbus_io_base + SMBHSTDAT0); smbus_delay();
- /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD); smbus_delay();
diff --git a/util/romcc/tests/raminit_test.c b/util/romcc/tests/raminit_test.c index 569d75b..b1baf7e 100644 --- a/util/romcc/tests/raminit_test.c +++ b/util/romcc/tests/raminit_test.c @@ -314,7 +314,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); diff --git a/util/romcc/tests/raminit_test1.c b/util/romcc/tests/raminit_test1.c index 569d75b..b1baf7e 100644 --- a/util/romcc/tests/raminit_test1.c +++ b/util/romcc/tests/raminit_test1.c @@ -314,7 +314,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); diff --git a/util/romcc/tests/raminit_test2.c b/util/romcc/tests/raminit_test2.c index d20ae6d..c5b366f 100644 --- a/util/romcc/tests/raminit_test2.c +++ b/util/romcc/tests/raminit_test2.c @@ -314,7 +314,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); diff --git a/util/romcc/tests/simple_test4.c b/util/romcc/tests/simple_test4.c index 2ac6a4d..bd3f52a 100644 --- a/util/romcc/tests/simple_test4.c +++ b/util/romcc/tests/simple_test4.c @@ -313,7 +313,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); @@ -383,7 +383,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_HSTCMD); diff --git a/util/romcc/tests/simple_test5.c b/util/romcc/tests/simple_test5.c index 976fa3d..e744f8f 100644 --- a/util/romcc/tests/simple_test5.c +++ b/util/romcc/tests/simple_test5.c @@ -141,7 +141,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); @@ -211,7 +211,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_HSTCMD); diff --git a/util/romcc/tests/simple_test6.c b/util/romcc/tests/simple_test6.c index 147614e..8aee0cd 100644 --- a/util/romcc/tests/simple_test6.c +++ b/util/romcc/tests/simple_test6.c @@ -137,7 +137,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL); - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD); /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD); @@ -207,7 +207,7 @@ /* setup transaction */ /* disable interrupts */ outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL); /* 3 */ - /* set the device I'm talking too */ + /* set the device I'm talking to */ outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD); /* 1 + 3 */ /* set the command/address... */ outb(address & 0xFF, SMBUS_IO_HSTCMD); /* 1 + 3 */ diff --git a/util/romcc/tests/simple_test61.c b/util/romcc/tests/simple_test61.c index 2b235cc..c0446e2 100644 --- a/util/romcc/tests/simple_test61.c +++ b/util/romcc/tests/simple_test61.c @@ -14,7 +14,7 @@ /* 0 == None, 1 == Parity, 2 == ECC */ if (byte != 2) continue;
- /* set the device I'm talking too */ + /* set the device I'm talking to */ __builtin_outb(device, 0x1004);
/* poll for transaction completion */
-
Jonathan Neuschäfer (Code Review)