Change in coreboot[master]: sc7180: Add QUPv3 FW load & config
Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 ) Change subject: sc7180: Add QUPv3 FW load & config ...................................................................... Patch Set 44: (1 comment) https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... File src/soc/qualcomm/sc7180/qupv3_config.c: https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... PS40, Line 75: /* To maintain Div=4 for QcLib, configure clock to 7372800Hz for sc7180 */
Checking with QcLib team UART driver can derive 115200 baud from any of the frequencies maintained by QUP clock table, usually from low to high. Here, as we are able to achieve 115200 baud from 7372800Hz frequency, so hope this is fine and no need of any fix from QcLib.
-- To view, visit https://review.coreboot.org/c/coreboot/+/35499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31 Gerrit-Change-Number: 35499 Gerrit-PatchSet: 44 Gerrit-Owner: mturney mturney <mturney@codeaurora.org> Gerrit-Reviewer: Doug Anderson <dianders@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Ravi kumar <rbokka@codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org> Gerrit-CC: Akash Asthana <akashast@qualcomm.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com> Gerrit-CC: Roja Rani Yarubandi <c_rojay@qualcomm.corp-partner.google.com> Gerrit-CC: Satya Priya Kakitapalli <c_skakit@qualcomm.corp-partner.google.com> Gerrit-CC: Stephen Boyd <swboyd@chromium.org> Gerrit-CC: Taniya Das <tdas@codeaurora.org> Gerrit-Comment-Date: Wed, 01 Apr 2020 07:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Roja Rani Yarubandi <c_rojay@qualcomm.corp-partner.google.com> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Roja Rani Yarubandi (Code Review)