Attention is currently required from: Bill XIE, Martin Roth, Stefan Reinauer.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 )
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File payloads/external/U-Boot/Kconfig:
https://review.coreboot.org/c/coreboot/+/60028/comment/813b217f_d05819d7
PS2, Line 12: UBOOT_STABLE
Could this be used instead of STABLE_COMMIT_ID in payloads/external/U-Boot/Makefile?
File payloads/external/U-Boot/Makefile:
https://review.coreboot.org/c/coreboot/+/60028/comment/5c4a0304_df1ecf1c
PS2, Line 28: git clone $(project_git_repo) $(project_dir)
This is fine but takes a little longer
We could try --branch $(STABLE_COMMIT_ID)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 12 Dec 2021 17:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Simon Glass (Code Review)