Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35794/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35794/2//COMMIT_MSG@9
PS2, Line 9: Modify DPTF parameters and TDP PL1 values to 15
1. Please add a dot/period at the end of sentences.
2. If possible, please split the commit up?
3. Where did you get these values from?
4. What tests pass now, which did not before?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858
Gerrit-Change-Number: 35794
Gerrit-PatchSet: 2
Gerrit-Owner: YenLu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YenLu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Anson Tseng
anson.tseng@intel.corp-partner.google.com
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Wed, 09 Oct 2019 12:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment