Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68634 )
Change subject: mb/google/kahlee: use override devicetrees for variants ......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/google/kahlee/variants/aleena/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68634/comment/e6b4074d_115f0c49 PS3, Line 38: chip drivers/generic/adau7002 : device generic 0.0 on end : end
can move to baseboard
Done
https://review.coreboot.org/c/coreboot/+/68634/comment/acfbbc25_e5c40721 PS3, Line 59: chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_119)" : register "sdmode_delay" = "5" : device generic 0.1 on end : end
can go to baseboard too
Done
https://review.coreboot.org/c/coreboot/+/68634/comment/8b12213d_8089599c PS3, Line 67: chip drivers/i2c/generic : register "hid" = ""ELAN0000"" : register "desc" = ""ELAN Touchpad"" : register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" : register "wake" = "7" : register "detect" = "1" : device i2c 15 on end : end
thanks for testing; i'll update the patch. wasn't 100% sure, so i went the safe route initially. […]
Done