Attention is currently required from: Subrata Banik, Angel Pons, Arthur Heymans, Lean Sheng Tan.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63627 )
Change subject: soc/intel/cmn/pch/lockdown: Perform additional SPI lock configuration
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/pch/lockdown/lockdown.c:
https://review.coreboot.org/c/coreboot/+/63627/comment/3341a1a7_7f7fdaa5
PS7, Line 63: die("SPI Cycle pending for too long!");
I don't know if die()ing is the right thing here; that should only be used in the rarest of circumstances, as this usually means you'll have to break out a physical programmer to reflash your BIOS.
Can we just print an error here and try to keep plodding along?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I922db8b46ac0d0523b91fc5aced88e38c8d8a560
Gerrit-Change-Number: 63627
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 15:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment