[M] Change in coreboot[master]: util/scripts: Add script to show platforms, CPU, type, and date added
Attention is currently required from: Felix Singer, Raul Rangel, Martin L Roth, Stefan Reinauer, Nicholas Chin.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63799 )
Change subject: util/scripts: Add script to show platforms, CPU, type, and date added ......................................................................
Patch Set 3:
(7 comments)
File util/scripts/show_platforms.sh:
https://review.coreboot.org/c/coreboot/+/63799/comment/38f08442_0df3f7c2 PS3, Line 20: ${platforms}
You could use an array instead to avoid any strange shell expansion: […]
Done
https://review.coreboot.org/c/coreboot/+/63799/comment/05b88320_10e02ef6 PS3, Line 21: echo
If you wanted to avoid the echo you could do the following: […]
Done
https://review.coreboot.org/c/coreboot/+/63799/comment/334d3de2_6958e013 PS3, Line 22: ${file/Kconfig/board_info.txt}
"${file}/Kconfig/board_info. […]
This is actually a replacement operator, replacing Kconfig with board_info.txt.
But you're right about the quotes - it's the one thing that I don't like about shfmt - it removes the quotes from around things when it doesn't feel like they're needed.
https://review.coreboot.org/c/coreboot/+/63799/comment/c9728246_9fe17fc2 PS3, Line 27: s|\s+select\s+||; s|\s+if.*||;
If you wanted to make this easier to read you can pass each expressing in with -e. […]
Done
https://review.coreboot.org/c/coreboot/+/63799/comment/8101a6f0_05997fc2 PS3, Line 29: file
same as above
Ack
https://review.coreboot.org/c/coreboot/+/63799/comment/ff7ff8d3_474ab439 PS3, Line 33: file
Same
Ack
https://review.coreboot.org/c/coreboot/+/63799/comment/55e2b9fe_2e203ef0 PS3, Line 33: grep "Category: " "${file/Kconfig/board_info.txt}" 2>/dev/null | sed 's/Category: //'
You could do this all with sed: […]
Done
-
Martin Roth (Code Review)