Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
HACK: mb/google/asurada: Keep sdram params in data section
Signed-off-by: Yidi Lin yidi.lin@mediatek.com Change-Id: I44e3f719dcfd66ff5e5cfac3658fca7ca35c8ad4 --- M src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c M src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47986/1
diff --git a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c index aa9c084..9fcc29bf 100644 --- a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c +++ b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c @@ -2,6 +2,6 @@
#include <soc/dramc_param.h>
-struct sdram_info params = { +struct sdram_info params __attribute((section (".data"))) = { .ddr_geometry = DDR_TYPE_2CH_2RK_4GB_2_2, }; diff --git a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c index aa9c084..9fcc29bf 100644 --- a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c +++ b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c @@ -2,6 +2,6 @@
#include <soc/dramc_param.h>
-struct sdram_info params = { +struct sdram_info params __attribute((section (".data"))) = { .ddr_geometry = DDR_TYPE_2CH_2RK_4GB_2_2, };
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47986/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/1/src/mainboard/google/asurad... PS1, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47986/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/1/src/mainboard/google/asurad... PS1, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47986/3/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/3/src/mainboard/google/asurad... PS3, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47986/3/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/3/src/mainboard/google/asurad... PS3, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47986/4/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/4/src/mainboard/google/asurad... PS4, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47986/4/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/4/src/mainboard/google/asurad... PS4, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47986/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/5/src/mainboard/google/asurad... PS5, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47986/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c:
https://review.coreboot.org/c/coreboot/+/47986/5/src/mainboard/google/asurad... PS5, Line 5: struct sdram_info params __attribute((section (".data"))) = { space prohibited between function name and open parenthesis '('
Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47986 )
Change subject: HACK: mb/google/asurada: Keep sdram params in data section ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Yidi Lin (Code Review)