Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58705 )
Change subject: mb/google/guybrush: Define ACPI Power Resources for FPMCU
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58705/comment/8eef6bad_23a622b2
PS4, Line 18: TEST
Only other test I think we need is to update the FPMCU FW. […]
_OFF method is not called. The FPMCU is enabled(EN_PWR_FP is 1) and is not in reset (SOC_FP_RST_L is 1) after the flash_fp_mcu script is run. The script instructs the use to reboot the device after updating the FP firmware. After rebooting, FP is functional.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52322eaecf6961ff9a196ca9ab2d58b7d4599d4f
Gerrit-Change-Number: 58705
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Craig Hesling
hesling@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 09 Nov 2021 06:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment