Attention is currently required from: Angel Pons, Name of user not set #1005283.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79979?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: mainboard: Add MSI MS-7788 ......................................................................
mainboard: Add MSI MS-7788
HACKS: * The SSKPD read hangs the boot, not sure why * I disabled it and everything seems to work... * I changed Sandybridge `chipset.cb` because I was getting warnings in my logs about leftover static devices * This is definitely not the correct way to do things, so I want to know what the right course of action actually _is_ * Do I leave the warning be? * Or is there something else I can do?
NOTES: * Been running this BIOS for a while: it's working well for the parts I've tested * MSI h61m-p31/w8 * Winbond 25Q64FVSIG * Fintek F71868A * I haven't hooked this up because there is no code specifically for this chip, I might experiment with the F71869AD code in the future, but right now it's working fine without BIOS superio support
Working: * PCIe graphics * Integrated graphics (libgfxinit) * USB (all ports) * Ethernet * All SATA ports * Serial output
Yet-to-be-thoroughly-tested: * Suspend states
Untested: * PS/2 * PCIe x1 lane
Signed-off-by: mrhh69 122405954+mrhh69@users.noreply.github.com Change-Id: Ia7830fcc7552e9734ec7c57e508a6a77f689e5b0 --- A src/mainboard/msi/ms7788/Kconfig A src/mainboard/msi/ms7788/Kconfig.name A src/mainboard/msi/ms7788/Makefile.mk A src/mainboard/msi/ms7788/acpi/ec.asl A src/mainboard/msi/ms7788/acpi/platform.asl A src/mainboard/msi/ms7788/acpi/superio.asl A src/mainboard/msi/ms7788/board_info.txt A src/mainboard/msi/ms7788/data.vbt A src/mainboard/msi/ms7788/devicetree.cb A src/mainboard/msi/ms7788/dsdt.asl A src/mainboard/msi/ms7788/gma-mainboard.ads A src/mainboard/msi/ms7788/gpio.c A src/mainboard/msi/ms7788/hda_verb.c M src/northbridge/intel/sandybridge/chipset.cb M src/northbridge/intel/sandybridge/romstage.c 15 files changed, 365 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/79979/5