Change in coreboot[master]: mb/google/herobrine: Use same I2C/SPI configs for piglin and hoglin - coreboot-gerrit

13 Nov 2021


      Attention is currently required from: Shelley Chen, mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59273 )
Change subject: mb/google/herobrine: Use same I2C/SPI configs for piglin and hoglin
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59273/comment/dcd095c0_a4a3fa03 
PS1, Line 56: GSI
Ugh. Why would they use GSI for I2C here. I don't think it buys anything... I guess a conversation for another day.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59273
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14497a205262ac1081c24631e4fd8d39bb804fce
Gerrit-Change-Number: 59273
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Comment-Date: Fri, 12 Nov 2021 23:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment