[S] Change in coreboot[main]: mb/google/rauru: Enable ChromeOS EC - coreboot-gerrit

30 Oct 2024


      Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84931?usp=email )
Change subject: mb/google/rauru: Enable ChromeOS EC
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/rauru/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84931/comment/8733e51b_b768a88d?usp... :
PS2, Line 20: 	mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 3 * MHz, 0);
I’d be great if you mentioned the datasheet in the commit message, where it’s specified, that it operates at 3 MHz.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84931?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I20828eee93975e75dfb777fe29d5e1c3454b5059
Gerrit-Change-Number: 84931
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-CC: Yidi Lin yidilin@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 12:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes