Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Christian Walter, Erik van den Bogaert, Frans Hendriks, Jason Nien, Lean Sheng Tan, Martin Roth, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Piotr Król, Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74452?usp=email
to look at the new patch set (#9).
Change subject: [WIP] SMBIOS: Move identification strings ......................................................................
[WIP] SMBIOS: Move identification strings
Platform code could provide the strings that are used to fill in SMBIOS type1, type2 and type3 tables. Change the code such that this board "identity" is initialized before creation of actual SMBIOS tables.
Default behaviour is to inherit type1 (system) from type2 (aka board) fields, and type3 (chassis) from type1 (system) fields.
For type3, manufacturer and asset_tag can now be individually set and may be different from those in type1 and type2 tables.
Some implementations of fetching SMBIOS string were not re-entrant.
Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/generic/cbfs-serial/cbfs-serial.c M src/drivers/i2c/at24rf08c/lenovo_serials.c M src/drivers/ocp/dmi/smbios.c M src/drivers/secunet/dmi/smbios.c M src/drivers/vpd/vpd_serial.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_smbios.c M src/include/identity.h M src/include/smbios.h M src/lib/identity.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/facebook/monolith/ramstage.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/drallion/variants/drallion/sku.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/glados/variants/lars/variant.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/variants/baseboard/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/sarien/sku.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/jasperlake_rvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/msi/ms7d25/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/smbios.c M src/mainboard/prodrive/hermes/smbios.c M src/mainboard/protectli/vault_cml/mainboard.c M src/mainboard/starlabs/lite/smbios.c M src/mainboard/starlabs/starbook/smbios.c M src/vendorcode/google/smbios.c 36 files changed, 342 insertions(+), 412 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/74452/9