[M] Change in coreboot[main]: mb/google/brox: Fix memory config

[Nick Vaccaro (Code Review)]

Attention is currently required from: Karthik Ramasubramanian, Shelley Chen.

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79355?usp=email )

Change subject: mb/google/brox: Fix memory config
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:

https://review.coreboot.org/c/coreboot/+/79355/comment/906431d9_16e5e9d6 :
PS3, Line 404: const struct pad_config *__weak variant_romstage_gpio_table(size_t *num)
             : {
> I am afraid the weak override here will be overridden by the table here - https://review.coreboot. […]

This table and weak declaration should remain here, but Karthik is correct that this will get overridden by the definition in variants/brox/gpio.c when on a brox reference platform variant.  Therefor, you need to make sure that the GPIOs in the romstage_gpio_table in this file are also in the rom_gpio_table in variants/brox/gpio.c.

Do you feel that the GPIOs in the romstage_gpio_table in variant/brox/gpio.c would not be common to many brox variants?  If they are likely to be common, those gpios should be added to the romstage_gpio_table in this file.