Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59135 )
Change subject: mb/google/brya/variants/primus: enable RTD3 for PCIe-eMMC bridge ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132930): https://review.coreboot.org/c/coreboot/+/59135/comment/073f924c_7abfe6c0 PS1, Line 21: if (child->chip_ops == &soc_intel_common_block_pcie_rtd3_ops) suspect code indent for conditional statements (16, 16)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132930): https://review.coreboot.org/c/coreboot/+/59135/comment/8ab38cb5_3a90f1d5 PS1, Line 22: rtd3_dev = child; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132930): https://review.coreboot.org/c/coreboot/+/59135/comment/cd94bc37_aa083338 PS1, Line 22: rtd3_dev = child; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132930): https://review.coreboot.org/c/coreboot/+/59135/comment/c66dcc5f_8f556b70 PS1, Line 28: rtd3_dev->enabled = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132930): https://review.coreboot.org/c/coreboot/+/59135/comment/c54481cd_7c89ed15 PS1, Line 34: devtree_update_emmc_rtd3(board_ver); please, no spaces at the start of a line