Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email )
Change subject: soc/mediatek/common: Refactor EINT driver ......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/83703/comment/668ebf2b_bd598adf?usp... : PS2, Line 123: void struct eint_regs
https://review.coreboot.org/c/coreboot/+/83703/comment/e1e03199_eb43da79?usp... : PS2, Line 122: void pos_bit_calc_for_eint(gpio_t gpio, u32 *pos, u32 *bit); : void *eint_find_reg_addr(gpio_t gpio); Since these functions are still declared here in gpio_common.h and are related to gpio, how about:
1. Rename eint_v1.c to gpio_eint_v1.c 2. Use `gpio_` prefix for these 2 functions (for example `gpio_get_eint_reg` and `gpio_calc_eint_pos_bit`)