Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Yu-Ping Wu, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62600 )
Change subject: commonlib/bsd: Remove cb_err_t ......................................................................
Patch Set 1:
(11 comments)
File payloads/libpayload/libc/fmap.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/5cd990ad_9d9025f9 PS1, Line 42: size_t *size)
Indentation.
Done
File payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/7b9425cf_ebea0c0d PS1, Line 60: union cbfs_mdata *mdata_out, size_t *data_offset_out)
Indentation.
Done
https://review.coreboot.org/c/coreboot/+/62600/comment/12b5d59d_f351ea2a PS1, Line 91: size_t *data_offset_out, struct vb2_hash *metadata_hash)
Indentation.
Done
File payloads/libpayload/tests/libcbfs/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/b9cd59ba_05a4e4bd PS1, Line 57: union cbfs_mdata *mdata_out, size_t *data_offset_out)
Indentation.
Done
https://review.coreboot.org/c/coreboot/+/62600/comment/17cc9079_f583b3bf PS1, Line 63: size_t *data_offset_out, struct vb2_hash *metadata_hash)
Indentation.
Done
File src/commonlib/bsd/cbfs_mcache.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/580a7936_85469f2c PS1, Line 44: size_t already_read, void *arg)
Indentation.
Done
File src/commonlib/bsd/cbfs_private.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/bf1a1b49_7bdbd89d PS1, Line 7: const size_t devsize)
Indentation.
Done
File src/drivers/parade/ps8640/ps8640.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/7946980a_b5d299b1 PS1, Line 84: static enum cb_err ps8640_bridge_aux_request(uint8_t bus, : uint8_t chip, : unsigned int target_reg, : unsigned int total_size, : enum aux_request request, : uint8_t *data)
nit: Can it be changed to occupy less lines?
I think this is a valid form of formatting code, and I don't want to overrule the original author's preferences in that respect. I'm just fixing things that were shifted around by my change.
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/84b9100b_1de7f9e2 PS1, Line 158: static enum cb_err sn65dsi86_bridge_aux_request(uint8_t bus, : uint8_t chip, : unsigned int target_reg, : unsigned int total_size, : enum aux_request request, : uint8_t *data)
nit: Can it be changed to occupy less lines?
see above
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/b25eacb6_e6e52aa4 PS1, Line 207: static enum cb_err mdss_dsi_send_init_cmd(enum mipi_dsi_transaction type, const u8 *body, u8 len)
line over 96 characters […]
Done
https://review.coreboot.org/c/coreboot/+/62600/comment/9b9b8cc8_d6207f00 PS1, Line 207: static enum cb_err mdss_dsi_send_init_cmd(enum mipi_dsi_transaction type, const u8 *body, u8 len)
line over 96 characters […]
Done
-
Julius Werner (Code Review)