Change in ...coreboot[master]: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE

[Shelley Chen (Code Review)]

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31852

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE

BUG=b:127310803
BRANCH=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I793363740fa0730a1e9e1aa7a9fa82d2789334b4
Signed-off-by: Shelley Chen 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31852/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 3c1f79e..15d052a 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -15,7 +15,8 @@
    select MAINBOARD_HAS_SPI_TPM_CR50
    select MAINBOARD_HAS_TPM2
    select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
-	select SOC_INTEL_WHISKEYLAKE
+	select SOC_INTEL_WHISKEYLAKE if BOARD_GOOGLE_HATCH_WHL
+	select SOC_INTEL_COMETLAKE if BOARD_GOOGLE_HATCH
    select SYSTEM_TYPE_LAPTOP

if BOARD_GOOGLE_BASEBOARD_HATCH

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31852/1/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/31852/1/src/mainboard/google/hatch/Kconfig@1... 
PS1, Line 18: select SOC_INTEL_WHISKEYLAKE if BOARD_GOOGLE_HATCH_WHL
            : 	select SOC_INTEL_COMETLAKE if BOARD_GOOGLE_HATCH
Let's just do this in Kconfig.name. That way we don't need to add "if BOARD..." here

[Shelley Chen (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31852

to look at the new patch set (#2).

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE

Move these configs to Kconfig.name as well.

BUG=b:127310803
BRANCH=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I793363740fa0730a1e9e1aa7a9fa82d2789334b4
Signed-off-by: Shelley Chen 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31852/2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

Patch Set 4: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

Patch Set 4:

Shelley, do you want to rebase your changes?

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

Patch Set 5:
> Patch Set 4:
>
> Shelley, do you want to rebase your changes?

Sorry, didn't keep up with this CL.  Thanks for the ping.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

Patch Set 5: Code-Review+2

[Shelley Chen (Code Review)]

Shelley Chen has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31852 )

Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE
......................................................................

mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE

Move these configs to Kconfig.name as well.

BUG=b:127310803
BRANCH=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I793363740fa0730a1e9e1aa7a9fa82d2789334b4
Signed-off-by: Shelley Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31852
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Subrata Banik 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Subrata Banik: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 3853c30..629b125 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -18,7 +18,6 @@
    select MAINBOARD_HAS_SPI_TPM_CR50
    select MAINBOARD_HAS_TPM2
    select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
-	select SOC_INTEL_WHISKEYLAKE
    select SYSTEM_TYPE_LAPTOP

if BOARD_GOOGLE_BASEBOARD_HATCH
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index fa743cd..e98bcae 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -3,7 +3,9 @@
 config BOARD_GOOGLE_HATCH
    bool "->  Hatch"
    select BOARD_GOOGLE_BASEBOARD_HATCH
+	select SOC_INTEL_COMETLAKE

config BOARD_GOOGLE_HATCH_WHL
    bool "->  Hatch_whl"
    select BOARD_GOOGLE_BASEBOARD_HATCH
+	select SOC_INTEL_WHISKEYLAKE