Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/49161
to review the following change.
Change subject: mb/google/dedede/var/sasuke: Enable ELAN touchpad ......................................................................
mb/google/dedede/var/sasuke: Enable ELAN touchpad
This change adds ELAN touchpad into devicetree for sasuke.
BUG=None
Change-Id: If9c25f23ee1c0e88382fff036f77a6753775b81e Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/49161/1
diff --git a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb index ca5de56..1cc4293 100644 --- a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb @@ -49,7 +49,16 @@ }" device domain 0 on device pci 14.0 on end - device pci 15.0 on end + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end # I2C 0 device pci 15.2 on end device pci 1c.7 on end device pci 19.0 on
Attention is currently required from: shkim. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49161 )
Change subject: mb/google/dedede/var/sasuke: Enable ELAN touchpad ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49161/comment/1c643d1b_75e8e575 PS1, Line 11: BUG=None Add TEST details for this and all the CLs in the series.
Attention is currently required from: shkim. Hello build bot (Jenkins), SH Kim, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49161
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/sasuke: Enable ELAN touchpad ......................................................................
mb/google/dedede/var/sasuke: Enable ELAN touchpad
This change adds ELAN touchpad into devicetree for sasuke.
BUG=None TEST=Built and verified touchpad function
Change-Id: If9c25f23ee1c0e88382fff036f77a6753775b81e Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/49161/2
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49161 )
Change subject: mb/google/dedede/var/sasuke: Enable ELAN touchpad ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49161/comment/d205decc_fc6d1b60 PS1, Line 11: BUG=None
Add TEST details for this and all the CLs in the series.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49161 )
Change subject: mb/google/dedede/var/sasuke: Enable ELAN touchpad ......................................................................
mb/google/dedede/var/sasuke: Enable ELAN touchpad
This change adds ELAN touchpad into devicetree for sasuke.
BUG=None TEST=Built and verified touchpad function
Change-Id: If9c25f23ee1c0e88382fff036f77a6753775b81e Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 10 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb index ca5de56..1cc4293 100644 --- a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb @@ -49,7 +49,16 @@ }" device domain 0 on device pci 14.0 on end - device pci 15.0 on end + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end # I2C 0 device pci 15.2 on end device pci 1c.7 on end device pci 19.0 on
-
Karthik Ramasubramanian (Code Review) -
Patrick Georgi (Code Review)
-
shkim (Code Review)