[XS] Change in coreboot[master]: mb/google/myst: Update PCIE_RST_L drive - coreboot-gerrit

10 Jun 2023


      Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin Roth, Tim Van Patten.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75700?usp=email )
Change subject: mb/google/myst: Update PCIE_RST_L drive
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75700/comment/8917718a_9bc601ba :
PS4, Line 55: 	PAD_NFO(GPIO_27, PCIE_RST1_L, LOW),
sorry, I am little confused here. Isn't low will keep device in reset? All we have to do is de-assert RST earlier in your previous patch. I'll test this next week.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75700?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f7a548a33eb18327139f033d7c0d6a1843f1639
Gerrit-Change-Number: 75700
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Sat, 10 Jun 2023 03:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment