Attention is currently required from: Jeremy Soller, Paul Menzel, Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65301 )
Change subject: mb/system76/adl-p: Add Darter Pro 8 ......................................................................
Patch Set 15:
(2 comments)
File src/mainboard/system76/adl-p/Kconfig:
https://review.coreboot.org/c/coreboot/+/65301/comment/f9fd634d_f3935b68 PS14, Line 25: TPM_MEASURED_BOOT
If it's not strictly required, this would provide more flexibility for people building their own cor […]
Done
File src/mainboard/system76/adl-p/ramstage.c:
https://review.coreboot.org/c/coreboot/+/65301/comment/bc4aa4e4_54a162f3 PS14, Line 25: params->SataPortsSolidStateDrive[1] = 1;
What does this do?
It might not actually do anything.
The description implies it's to declare that a SATA port is an SSD and not an HDD. The actual code just sets some extra bits in the PCI config related to thermal throttling, but only if `SataThermalSuggestedSetting=1`.
-
Tim Crawford (Code Review)