Attention is currently required from: Henry Sun, Ren Kuo, Paul Menzel, Simon Yang, Angel Pons, Kane Chen, Karthik Ramasubramanian.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60301 )
Change subject: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60301/comment/417f4202_95560d89
PS9, Line 12: per Intel recommendation
If Ren choice to change it by function mainboard_silicon_init_params() in ramstage.c, maybe I can drop my change first, and once FSP updated, I can go back here to update related header file, what do you think?
It's already written, so let's just get it in. :)
It would be nice to mention as much as possible about the FSP issue in the
commit message. So if somebody else runs into this problem, they'd know
what to do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34
Gerrit-Change-Number: 60301
Gerrit-PatchSet: 10
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 30 Dec 2021 12:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Gerrit-MessageType: comment