Ronak Kanabar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44576 )
Change subject: soc/intel/jasperlake: use edk2-stable202005 headers ......................................................................
soc/intel/jasperlake: use edk2-stable202005 headers
FSP uses latest EDK2 code base. So, switch to edk2-stable202005 header files instead of UDK2017 header files for JSL.
BUG=b:162184827 BRANCH=None TEST=Build and boot JSLRVP
Cq-Depend: chrome-internal:3221772 Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: Ieed1b58e491d5a89043c418f0f44f2ee9af111f5 --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/44576/1
diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index 7321425..c42adfc 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -59,7 +59,7 @@ select SUPPORT_CPU_UCODE_IN_CBFS select TSC_MONOTONIC_TIMER select UDELAY_TSC - select UDK_2017_BINDING + select UDK_202005_BINDING select DISPLAY_FSP_VERSION_INFO select HECI_DISABLE_USING_SMM
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Aamir Bohra, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44576
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: use UDK_202005_BINDING ......................................................................
soc/intel/jasperlake: use UDK_202005_BINDING
JSL FSP support FSP 2.2. FSP 2.2 introduces Multiphase SI init support through the FSP-S arch UPD. The FSP-S arch UPD structure is added in edk2 stable 2020 branch. Switching the support for JSL to edk2-stable202005 to intercept the FSP2.2 related support.
BUG=b:162184827 BRANCH=None TEST=Build and boot JSLRVP
Cq-Depend: chrome-internal:3221772 Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: Ieed1b58e491d5a89043c418f0f44f2ee9af111f5 --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/44576/2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44576 )
Change subject: soc/intel/jasperlake: use UDK_202005_BINDING ......................................................................
Patch Set 2: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44576 )
Change subject: soc/intel/jasperlake: use UDK_202005_BINDING ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44576 )
Change subject: soc/intel/jasperlake: use UDK_202005_BINDING ......................................................................
soc/intel/jasperlake: use UDK_202005_BINDING
JSL FSP support FSP 2.2. FSP 2.2 introduces Multiphase SI init support through the FSP-S arch UPD. The FSP-S arch UPD structure is added in edk2 stable 2020 branch. Switching the support for JSL to edk2-stable202005 to intercept the FSP2.2 related support.
BUG=b:162184827 BRANCH=None TEST=Build and boot JSLRVP
Cq-Depend: chrome-internal:3221772 Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: Ieed1b58e491d5a89043c418f0f44f2ee9af111f5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44576 Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aamir Bohra: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index 7321425..c42adfc 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -59,7 +59,7 @@ select SUPPORT_CPU_UCODE_IN_CBFS select TSC_MONOTONIC_TIMER select UDELAY_TSC - select UDK_2017_BINDING + select UDK_202005_BINDING select DISPLAY_FSP_VERSION_INFO select HECI_DISABLE_USING_SMM
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44576 )
Change subject: soc/intel/jasperlake: use UDK_202005_BINDING ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 5/2/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16399 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16398 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16397 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16396 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16395 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/16401 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16400
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aamir Bohra (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Ronak Kanabar (Code Review)