HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h> ......................................................................
src: Remove unused 'include <bootblock_common.h>
Change-Id: I9eedae837634beb5a545d97fdf9c1810faba5138 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-power8/bootblock.c M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/mainboard.c M src/mainboard/google/trogdor/mainboard.c M src/soc/intel/apollolake/fspcar.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/skylake/fspcar.c 7 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/37271/1
diff --git a/src/mainboard/emulation/qemu-power8/bootblock.c b/src/mainboard/emulation/qemu-power8/bootblock.c index ec30c87..d59ab37 100644 --- a/src/mainboard/emulation/qemu-power8/bootblock.c +++ b/src/mainboard/emulation/qemu-power8/bootblock.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <bootblock_common.h> #include <console/console.h> #include <program_loading.h>
diff --git a/src/mainboard/google/cheza/mainboard.c b/src/mainboard/google/cheza/mainboard.c index 7a19d32..804906a 100644 --- a/src/mainboard/google/cheza/mainboard.c +++ b/src/mainboard/google/cheza/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <bootblock_common.h> #include <gpio.h> #include <soc/usb.h>
diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c index d50758c..e36a1c7 100644 --- a/src/mainboard/google/mistral/mainboard.c +++ b/src/mainboard/google/mistral/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <bootblock_common.h> #include <vendorcode/google/chromeos/chromeos.h> #include <soc/usb.h>
diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index ce03ce1..4df87e5 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <bootblock_common.h> #include <arch/mmio.h> #include <gpio.h> #include <timestamp.h> diff --git a/src/soc/intel/apollolake/fspcar.c b/src/soc/intel/apollolake/fspcar.c index a284116..40bacd7 100644 --- a/src/soc/intel/apollolake/fspcar.c +++ b/src/soc/intel/apollolake/fspcar.c @@ -13,7 +13,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <bootblock_common.h> + #include <FsptUpd.h>
const FSPT_UPD temp_ram_init_params = { diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index 96218f4..6294b8a 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -17,7 +17,6 @@ #include <stdint.h> #include <arch/cbfs.h> #include <arch/romstage.h> -#include <bootblock_common.h> #include <bootmode.h> #include <cbmem.h> #include <console/console.h> diff --git a/src/soc/intel/skylake/fspcar.c b/src/soc/intel/skylake/fspcar.c index 0d27f57..4e8b5e7 100644 --- a/src/soc/intel/skylake/fspcar.c +++ b/src/soc/intel/skylake/fspcar.c @@ -13,7 +13,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <bootblock_common.h> + #include <FsptUpd.h>
const FSPT_UPD temp_ram_init_params = {
Hello Patrick Rudolph, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37271
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
src: Remove unused 'include <bootblock_common.h>'
Change-Id: I9eedae837634beb5a545d97fdf9c1810faba5138 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-power8/bootblock.c M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/mainboard.c M src/mainboard/google/trogdor/mainboard.c M src/soc/intel/apollolake/fspcar.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/skylake/fspcar.c 7 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/37271/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, ron minnich, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37271
to look at the new patch set (#3).
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
src: Remove unused 'include <bootblock_common.h>'
Change-Id: I9eedae837634beb5a545d97fdf9c1810faba5138 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-power8/bootblock.c M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/mainboard.c M src/mainboard/google/trogdor/mainboard.c M src/soc/intel/apollolake/fspcar.c M src/soc/intel/broadwell/romstage/romstage.c 6 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/37271/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
Patch Set 3: Code-Review+1
Hello Patrick Rudolph, ron minnich, Arthur Heymans, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37271
to look at the new patch set (#4).
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
src: Remove unused 'include <bootblock_common.h>'
Change-Id: I9eedae837634beb5a545d97fdf9c1810faba5138 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-power8/bootblock.c M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/mainboard.c M src/mainboard/google/trogdor/mainboard.c M src/soc/intel/apollolake/fspcar.c M src/soc/intel/broadwell/romstage/romstage.c 6 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/37271/4
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
Patch Set 5: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
Patch Set 5: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37271 )
Change subject: src: Remove unused 'include <bootblock_common.h>' ......................................................................
src: Remove unused 'include <bootblock_common.h>'
Change-Id: I9eedae837634beb5a545d97fdf9c1810faba5138 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37271 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/emulation/qemu-power8/bootblock.c M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/mainboard.c M src/mainboard/google/trogdor/mainboard.c M src/soc/intel/apollolake/fspcar.c M src/soc/intel/broadwell/romstage/romstage.c 6 files changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/src/mainboard/emulation/qemu-power8/bootblock.c b/src/mainboard/emulation/qemu-power8/bootblock.c index ec30c87..d59ab37 100644 --- a/src/mainboard/emulation/qemu-power8/bootblock.c +++ b/src/mainboard/emulation/qemu-power8/bootblock.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <bootblock_common.h> #include <console/console.h> #include <program_loading.h>
diff --git a/src/mainboard/google/cheza/mainboard.c b/src/mainboard/google/cheza/mainboard.c index 7a19d32..804906a 100644 --- a/src/mainboard/google/cheza/mainboard.c +++ b/src/mainboard/google/cheza/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <bootblock_common.h> #include <gpio.h> #include <soc/usb.h>
diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c index d50758c..e36a1c7 100644 --- a/src/mainboard/google/mistral/mainboard.c +++ b/src/mainboard/google/mistral/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <bootblock_common.h> #include <vendorcode/google/chromeos/chromeos.h> #include <soc/usb.h>
diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index 63fac19..0dd2624 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <bootblock_common.h> #include <device/device.h> #include <device/mmio.h> #include <gpio.h> diff --git a/src/soc/intel/apollolake/fspcar.c b/src/soc/intel/apollolake/fspcar.c index a284116..40bacd7 100644 --- a/src/soc/intel/apollolake/fspcar.c +++ b/src/soc/intel/apollolake/fspcar.c @@ -13,7 +13,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <bootblock_common.h> + #include <FsptUpd.h>
const FSPT_UPD temp_ram_init_params = { diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index 96218f4..6294b8a 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -17,7 +17,6 @@ #include <stdint.h> #include <arch/cbfs.h> #include <arch/romstage.h> -#include <bootblock_common.h> #include <bootmode.h> #include <cbmem.h> #include <console/console.h>
-
Arthur Heymans (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Paul Menzel (Code Review)