Attention is currently required from: Eric Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63773 )
Change subject: mb/prodrive/atlas: Fix build error
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63773/comment/092e4a5d_71bd92e2
PS3, Line 7: mb/prodrive/atlas: Fix build error
Thank yo ufor the patch. Next time, it’d be great if you use a more specific commit message summary. Maybe something like
Use MEMORY_MAPPED_TPM in Kconfig to fix build
https://review.coreboot.org/c/coreboot/+/63773/comment/0cbe17fb_7cf07113
PS3, Line 9: commit c6b041a12e
Commit c6b041a12e (tpm: Refactor TPM Kconfig dimensions) …
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff7e20ac271eb5b2afc9061819e2cc0cf2264cbf
Gerrit-Change-Number: 63773
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 06:03:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment