Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: WIP soc: Added dram information to cbmem WIP ......................................................................
Patch Set 3:
(80 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/2a3cab91_0e92188a PS3, Line 27: #if TEST_CODE /* Added this structure for testing purpose, will be remove once changes are reviewd */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/1b9f9485_bb3b4cd2 PS3, Line 30: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/3057ac40_71ea59af PS3, Line 31: uint64_t type; // enum that differentiates DDR3, LPDDR3, LPDDR4, etc. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/18af3e6a_2363aeb4 PS3, Line 32: uint64_t num_channels; // To know how may channels are available. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/282bd7de_454fd97a PS3, Line 33: uint64_t reserved[6]; // Reserved [6] please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/b217870f_cd847da2 PS3, Line 34: struct please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/481a5992_b3737594 PS3, Line 35: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/aabacd0b_e3aa362d PS3, Line 35: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/37db3e7d_32d99f77 PS3, Line 36: uint64_t density; // Total density Seen on channel code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/3b196c72_74bd3a60 PS3, Line 36: uint64_t density; // Total density Seen on channel please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/1af82e1a_1688533d PS3, Line 37: uint64_t io_width; // JEDEC MR8 - io width code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/97e8146c_c5f72c46 PS3, Line 37: uint64_t io_width; // JEDEC MR8 - io width please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f204a8bb_466ef8f6 PS3, Line 38: uint64_t manufacturer_id; // JEDEC MR5 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/0451a206_d50f26f7 PS3, Line 38: uint64_t manufacturer_id; // JEDEC MR5 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f0609460_f2c7b196 PS3, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/70002217_0380a861 PS3, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/52d9c20d_99ad6eb7 PS3, Line 40: uint64_t reserved[4]; // Reserved code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/c035b0b9_e5f44dc4 PS3, Line 40: uint64_t reserved[4]; // Reserved please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/4f8e483e_56c22f73 PS3, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ce565650_1702aa65 PS3, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/2d3fc400_214a2504 PS3, Line 42: } channels[DDR_MAX_NUM_CH_TEST]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/cd1f9a21_9b784134 PS3, Line 43: }dram_info; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/68fbd94f_d30bba96 PS3, Line 48: /* Save MEM CHIP info in SRAM region to share with ramstage */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/33b5842f_01b959ec PS3, Line 49: mem_chip_offset = (void *)te->blob_address; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/c15b3a92_504e2a46 PS3, Line 49: mem_chip_offset = (void *)te->blob_address; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/3f4db4df_16826fb6 PS3, Line 50: mem_chip_size = te->size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f82de36e_e2917b02 PS3, Line 50: mem_chip_size = te->size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/096507df_95b24e9e PS3, Line 55: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information before adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/33057bfb_31f7976a PS3, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/2196965f_9f2f94e5 PS3, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f9a5523e_b84ef4b4 PS3, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/6ede1534_98c8b18b PS3, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/593f03da_662954ec PS3, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/2d6454c8_a26cc63a PS3, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/511cd475_6ae9d532 PS3, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/49c7b481_339cd17e PS3, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/66ce93f2_c47c77b6 PS3, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ed91b202_2050998e PS3, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/5eeeb501_efc4827f PS3, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ec52a828_7fae0a96 PS3, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/7696a1fd_3e358ab3 PS3, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/b281386c_3c01109b PS3, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ab41e4b6_47d0385e PS3, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/323d0fd1_ac9ea436 PS3, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/c13052d4_d3bc8322 PS3, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ae9bba23_d1751201 PS3, Line 66: void *mem_region_base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ae7265d1_cc803d3e PS3, Line 66: void *mem_region_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ba6c75a7_baaccaeb PS3, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/60c16dc3_ffbf61fe PS3, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/70f072c0_9c963bbf PS3, Line 70: ASSERT(mem_region_base != NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/454f4f49_a520a6ce PS3, Line 70: ASSERT(mem_region_base != NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/b8b061f0_8242a6fe PS3, Line 72: /* Migrate the data into CBMEM */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/88319aa1_85ad6c8e PS3, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/8d65e273_ad44624d PS3, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/41f43376_44943f4f PS3, Line 77: /* Test Code to print memchip information after adding cbmem_addd */ 'addd' may be misspelled - perhaps 'add'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/6ea9e172_4b34eb91 PS3, Line 78: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information after adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/2284e691_88d78a44 PS3, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/5d40337f_de083776 PS3, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/37787f7d_86cbe631 PS3, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/3a97333f_c247fe80 PS3, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/6e600160_182700ee PS3, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/eee52ddd_fe6cbcd9 PS3, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/7a63d90f_9247f9e3 PS3, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/ebb00ab7_68637ede PS3, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/7a5dae3b_4660a167 PS3, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/0dcf095e_a9bbd760 PS3, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/a1b49e09_3ae5554c PS3, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/95254064_fedf94d9 PS3, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f60eef39_8a5bca4b PS3, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/f14eb484_6e6c8b69 PS3, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/687cfd24_9f652d52 PS3, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/bf959b74_9724a1d0 PS3, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/41102c88_649d515b PS3, Line 157: sizeof(te->name))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/52aa6be7_dbc36faf PS3, Line 157: sizeof(te->name))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/d3e92b00_eb59f32a PS3, Line 158: write_mem_chip_information(te); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/9519b3c5_ee7a06bb PS3, Line 158: write_mem_chip_information(te); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/a8803352_51847e95 PS3, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/8deecfb9_cc5db60c PS3, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/166ee144_f6254676 PS3, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133419): https://review.coreboot.org/c/coreboot/+/59195/comment/870c24d6_34fd8b27 PS3, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)