Attention is currently required from: Mario Scheithauer, Angel Pons, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 )
Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I gave it a test on mc_ehl1 and all seems to be fine here.
I would update the commit message to make clear that de-selecting these Kconfig switches activates cse_final_ready_to_boot() and cse_final_end_of_firmware() in the common cse driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6
Gerrit-Change-Number: 63762
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 07:58:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment