Attention is currently required from: Tarun Tuli, Raymond Chung, Nick Vaccaro, Eric Lai, Zhuohao Lee.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69137 )
Change subject: mb/google/brya/var/gaelin: Configure devicetree settings
......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3:
ign
File src/mainboard/google/brya/variants/gaelin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69137/comment/49d38bd3_fbcaa2ae
PS3, Line 27: # Enable HDMI in Port B
: register "ddi_portB_config" = "0"
we don't need this
https://review.coreboot.org/c/coreboot/+/69137/comment/22babb73_afaabac0
PS3, Line 59:
use tab
https://review.coreboot.org/c/coreboot/+/69137/comment/cec9295f_1e9cc51d
PS3, Line 60:
please align this entire section with a tab
https://review.coreboot.org/c/coreboot/+/69137/comment/ef05ac83_46c6e1d4
PS3, Line 122:
use tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a741feec52cf73da8d6ec0b03cc93d6a4cba256
Gerrit-Change-Number: 69137
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bruce Chiang
brucechiang@msi.corp-partner.google.com
Gerrit-CC: Eason Chang
easonchang@msi.corp-partner.google.com
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 09:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment