Attention is currently required from: Paul Menzel, Shuming Chu (Shuming), Angel Pons, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68902 )
Change subject: src/include/smbios: Add definition for smbios type 4 and type 9
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/68902/comment/013829a1_2d0ade99
PS1, Line 487: #define SMBIOS_PROCESSOR_FAMILY_XEON 0xb3
Where is this define used? Does it really belong in here?
https://review.coreboot.org/c/coreboot/+/68902/comment/ad93c2bd_b4159665
PS1, Line 488: #define PROCESSOR_64BIT_CAPABLE BIT(2)
: #define PROCESSOR_MULTI_CORE BIT(3)
: #define PROCESSOR_POWER_PERFORMANCE_CONTROL BIT(7)
Hmmm, let's not use `BIT()` for consistency with existing macros
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I559995b0204f8e5bdeef2c0f8b394f9011d72240
Gerrit-Change-Number: 68902
Gerrit-PatchSet: 1
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment